fix: Lower log level for internal protocol connection details #637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lash-L
previously approved these changes
Dec 6, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces log noise by lowering the severity level of internal protocol connection messages from warning to debug. These messages represent expected operational states in the device manager's fallback mechanism between MQTT and local channels, rather than actionable errors.
Key Changes:
- Changed command failure logs from warning to debug when falling back between channels
- Lowered connection state messages (already connected, connection lost, initial connection failures) to debug level
- Improved message clarity for the first local connection attempt to indicate retry behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| roborock/devices/v1_channel.py | Reduced log levels for command failures on channels (line 93) and initial local connection attempts (line 285) to debug |
| roborock/devices/local_channel.py | Lowered "already connected" state (line 179) and connection loss events (line 217) to debug level |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lash-L
approved these changes
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lower noisy log messages for internal device manager connections state details across mqtt / local mixed channels. We'll instead rely on command failure symptoms and diagnose details with debug logs.
Fixes #616